This repository has been archived by the owner on Sep 5, 2020. It is now read-only.
[installer] adjust name of installation-folder #1213
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1178
There is some minor problem with the package name..
electron-builder’s name variable will be used for linux and win as well:
%localappdata%
but will cut off anything starting with an {dash, space, point} as NuGet will internally convert - for example - spaces to%20
but won't allow%
for package ids...best would be IMHO:
Ethereum-Wallet
ethereum-wallet
...possible would be:
EthereumWallet
ethereumwallet
edit 9/28: There might be a solution, follow the white rabbit......